feat: add CloudWatch event rules and add missed CloudWatch log outputs

cloudposse / terraform-aws-lambda-function

A module for launching Lambda Fuctions

https://cloudposse.com/accelerate

Apache License 2.0

30 stars 40 forks source link

feat: add CloudWatch event rules and add missed CloudWatch log outputs #35

Closed arichtman closed 6 months ago

arichtman commented 1 year ago

what

add CloudWatch event rules
add missed CloudWatch log outputs
remove variable sns_subscriptions

why

CloudWatch event rules are useful for invoking lambda by cron expressions
CloudWatch log out puts are useful for external usage
sns_subscriptions is an unused variables

references

Closes #27

arichtman commented 1 year ago

This is a resubmission of #29

Gowiem commented 11 months ago

@arichtman sorry we've let this sit un-reviewed for so long. I can help drive it forward if you're willing to pick it back up as it looks like a good addition of functionality that we'd appreciate to get into the project. Can you pull in main locally, deal with conflicts, address feedback, and push your changes? Please ping me when it's ready and I'll be happy to review. Thanks for the contribution and I look forward to getting this in!

arichtman commented 11 months ago

@SweetOps has done the work here so far. I didn't want to steal anyone's credit so this is just a resubmission of the PR. I don't have access to this repository to make any adjustments.

SweetOps commented 9 months ago

I didn't want to steal anyone's credit so this is just a resubmission of the PR.

@arichtman, I do appreciate it. However, feel free to open PR from the your repo if you're still interested in these changes.

mergify[bot] commented 6 months ago

This pull request is now in conflict. Could you fix it @arichtman? 🙏