cloudposse / terraform-aws-lambda-function

A module for launching Lambda Fuctions
https://cloudposse.com/accelerate
Apache License 2.0
30 stars 40 forks source link

chore(deps): update terraform cloudposse/cloudwatch-logs/aws to v0.6.7 (main) - abandoned #38

Closed renovate[bot] closed 11 months ago

renovate[bot] commented 1 year ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/cloudwatch-logs/aws (source) module patch 0.6.6 -> 0.6.7

Release Notes

cloudposse/terraform-aws-cloudwatch-logs ### [`v0.6.7`](https://togithub.com/cloudposse/terraform-aws-cloudwatch-logs/releases/tag/0.6.7) [Compare Source](https://togithub.com/cloudposse/terraform-aws-cloudwatch-logs/compare/0.6.6...0.6.7) ##### 🚀 Enhancements
Fix mistake in policy @​ramses999 (#​38) ##### what Fix mistake in policy ##### why The policy is created simply by ARN without the ":" construct, which is necessary to create the correct policy for the role. Without this ":" construct, the policy is created, but it does not work correctly. This error was discovered when I tried to create a cloudwatch group in the cloudtrail module. I got the response "Error: Error updating CloudTrail: InvalidCloudWatchLogsLogGroupArnException: Access denied. Verify in IAM that the role has adequate permissions." After studying the code, I realized that I need to add the construction ":*" in a couple of lines. My solution looks like this, I need to replace the lines in [file](https://togithub.com/cloudposse/terraform-aws-cloudwatch-logs/blob/master/iam.tf) : This line: join("", aws_cloudwatch_log_group.default.*.arn), replaced by "${join("", aws_cloudwatch_log_group.default.*.arn)}:\*" You need to do this in both identical lines. Perhaps you can suggest a better solution, I'm new to terraforming. ##### references [https://github.com/cloudposse/terraform-aws-cloudwatch-logs/issues/37](https://togithub.com/cloudposse/terraform-aws-cloudwatch-logs/issues/37) https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/master/iam.tf#L55

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] commented 1 year ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

âš  Warning: custom changes will be lost.

Gowiem commented 1 year ago

/test all

renovate[bot] commented 11 months ago

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Gowiem commented 11 months ago

Closing as their is an upgrade to another patch version that is already open.