Closed MaxymVlasov closed 2 weeks ago
@milldr also I'm curious - do you have tests that check upgrade (print out tf plan
changes) from current version to changes in PR, or only test that PR pass creation-removal resources tests?
@milldr also I'm curious - do you have tests that check upgrade (print out tf plan changes) from current version to changes in PR, or only test that PR pass creation-removal resources tests?
In most modules we do, but looks like we don't here. I'll revert the last release
To be honest, I think hardcoding /aws/lambda/
is creating issues. I understand that's by default what lambda does if you create it on the UI but we have the freedom to allow the user to chose their pattern if they wish. I will propose a new PR trying to deal with that, let me give another go :)
I've opened PR #79 to revert the changes and add tests and necessary outputs to catch any breaking changes going forward
Describe the Bug
74 actually breaks
aws_cloudwatch_log_group
namesExpected Behavior
name
should be not changed https://github.com/cloudposse/terraform-aws-lambda-function/pull/74/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR15Possible solution: Provide all
context
variables exceptname
Steps to Reproduce
Screenshots
No response
Environment
No response
Additional Context
No response