cloudposse / terraform-aws-rds

Terraform module to provision AWS RDS instances
https://cloudposse.com/accelerate
Apache License 2.0
157 stars 181 forks source link

Terraform 0.13 requires snapshot_identifier explicitly set to null #106

Closed nnsense closed 3 years ago

nnsense commented 3 years ago

what

why

It seems resource "aws_db_instance" "default" defined into main changed (apparently, an hour ago?) its flexibility in taking arguments. Before (also with 0.13) defining "" was enough to use username and password for the DB. Now, I've got this:

Error: ConflictsWith                                                                                                                                                                       

  on .terraform/modules/rds_instance/main.tf line 44, in resource "aws_db_instance" "default":                                                                                             
  44:   snapshot_identifier         = var.snapshot_identifier                                                                                                                              

"snapshot_identifier": conflicts with username 

references

No references, and I might even be wrong, I rely on your testing to confirm the issue ;)

Gowiem commented 3 years ago

/test all

Gowiem commented 3 years ago

@nnsense can you push an empty commit via git commit --allow-empty -m "Trigger GH Action" and then git push. We're having issues with our GH actions not triggering / reporting back status sometimes and the only way to force it is with a new commit.

Once we've got a green build then we'll get this merged. Thanks!

Gowiem commented 3 years ago

/test all