cloudposse / terraform-aws-rds

Terraform module to provision AWS RDS instances
https://cloudposse.com/accelerate
Apache License 2.0
156 stars 181 forks source link

fix 'Warning: Argument is deprecated' db_name #140

Closed elkh510 closed 2 years ago

elkh510 commented 2 years ago

what

why

│ Warning: Argument is deprecated
│ 
│   with module.rds_instance.aws_db_instance.default,
│   on .terraform/modules/rds_instance/main.tf line 26, in resource "aws_db_instance" "default":
│   26:   name                  = var.database_name
│ 
│ Use db_name instead
│ 
│ (and one more similar warning elsewhere)

references

N/A

mergify[bot] commented 2 years ago

This pull request is now in conflict. Could you fix it @elkh510? 🙏

nitrocode commented 2 years ago

@elkh510 in other to use db_name instead of name argument, we would have to bump the aws provider in versions.tf (and in examples/ directories) to the applicable 4.x aws provider version.

joe-niland commented 2 years ago

/test all

nitrocode commented 2 years ago

Please change in examples/*/versions.tf

nitrocode commented 2 years ago

/test all