search

cloudposse / terraform-aws-rds

Terraform module to provision AWS RDS instances
https://cloudposse.com/accelerate
Apache License 2.0
153 stars 180 forks source link

fix: Default iops to null (#168) #176

Closed kbolino closed 5 months ago

kbolino commented 5 months ago

what

The default value of the iops variable is changed from 0 to null.

why

Resolves an issue with gp3 storage type when allocated storage is below 400 GB. This shouldn't cause problems in other cases, as the parameter is optional at the provider level.

references

gberenice commented 5 months ago

/terratest

gberenice commented 5 months ago

@kbolino thank you for the contribution! The tests are currently failing due to the combination of parameters that is not supported by Amazon RDS anymore:

Error: creating RDS DB Instance (eg-test-rds-test-37868): InvalidParameterCombination: RDS does not support creating a DB instance with the following combination: DBInstanceClass=db.t2.small, Engine=mysql, EngineVersion=5.7.44, LicenseModel=general-public-license. For supported combinations of instance class and database engine version, see the documentation.

Could I ask you to update the instance type to db.t3.micro in the examples? 🙏

gberenice commented 5 months ago

/terratest