cloudposse / terraform-aws-rds

Terraform module to provision AWS RDS instances
https://cloudposse.com/accelerate
Apache License 2.0
157 stars 180 forks source link

add(outputs): paramter_group_name and option_group_name #181

Closed flightlesstux closed 6 months ago

flightlesstux commented 6 months ago

what

Output values are added.

why

We need to pass the variables to the RDS.

db_options variable logic is also fixed.

references

n/a

joe-niland commented 6 months ago

@aknysh are we still using make github/init? I thought it was deprecated.

flightlesstux commented 6 months ago

@flightlesstux thanks you.

Please see comments, and please also run

make init
make github/init
make readme

and commit the changes

Thank you for your help @aknysh.

mergify[bot] commented 6 months ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

aknysh commented 6 months ago

@aknysh are we still using make github/init? I thought it was deprecated.

@joe-niland I'm not sure, but the command did update the files in .github folder

mergify[bot] commented 6 months ago

💥 This pull request now has conflicts. Could you fix it @flightlesstux? 🙏

flightlesstux commented 6 months ago

PR closed due to not necessary commits. Sorry for this.