Add availability zone option

simonsparks commented 3 years ago

what

Exposes the aws_db_instance's availability_zone option as an option on this module.
Ignores any value set for the availability_zone option if this module's multi_az option is set to true.

why

Being able to use this module with minimal resources initially, and scale up later when required, would be useful.

references

closes #93

SweetOps commented 3 years ago

/rebuild-readme

SweetOps commented 3 years ago

@simonsparks could you run the following commands locally and commit:

make init
make readme
terraform fmt

simonsparks commented 3 years ago

Hi @SweetOps I had a go at running these commands but I'm getting an error with the make readme step (running on macOS):

$ make readme
* Installing packages master...
Cloning into '/Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor/packages'...
remote: Enumerating objects: 771, done.
remote: Counting objects: 100% (771/771), done.
remote: Compressing objects: 100% (399/399), done.
remote: Total 771 (delta 266), reused 467 (delta 172), pack-reused 0
Receiving objects: 100% (771/771), 7.86 MiB | 3.28 MiB/s, done.
Resolving deltas: 100% (266/266), done.
* Installing gomplate to /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor
mkdir -p /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor
curl --retry 3 --retry-delay 5 --fail -sSL -o /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor/gomplate https://github.com/hairyhenderson/gomplate/releases/download/v3.9.0/gomplate_darwin-amd64-slim && chmod +x /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor/gomplate
* Installing terraform-docs to /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor
mkdir -p /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor
curl --retry 3 --retry-delay 5 --fail -sSL -o /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor/terraform-docs https://github.com/segmentio/terraform-docs/releases/download/v0.11.0/terraform-docs-v0.11.0-darwin-amd64 && chmod +x /Users/simon/Development/SparksCreative/forked/cloudposse/terraform-aws-rds/build-harness/vendor/terraform-docs
make: gomplate: No such file or directory
make: *** [readme/build] Error 1

Any ideas?

maximmi commented 3 years ago

@simonsparks

Any ideas?

We can update docs/readme in your PR automatically if you will grant access to your fork. It might be easier

simonsparks commented 3 years ago

Sure @maximmi Who / what needs access?

SweetOps commented 3 years ago

@simonsparks

Who / what needs access?

https://github.com/cloudpossebot

simonsparks commented 3 years ago

@SweetOps @maximmi cloudpossebot has been invited for write access

SweetOps commented 3 years ago

/rebuild-readme

SweetOps commented 3 years ago

cloudpossebot has been invited for write access

sorry, I forgot that need to accept invite in email so it is not our way

@simonsparks could you open the new PR from your user-fork repo (not organization fork as you did)

simonsparks commented 3 years ago

Hi @SweetOps, I've created a new PR at #108 from my personal account as requested. cloudpossebot has been invited to collaborate again.

I tried to run the make commands again (even spun up a linux VM as an alternative environment) but still get errors. Let me know if there's anything else I can do.

aknysh commented 3 years ago

superseded by https://github.com/cloudposse/terraform-aws-rds/pull/108

cloudposse / terraform-aws-rds

Add availability zone option #94

what

why

references