More accurate control of create before destroy behaviors - Githubissues

cloudposse / terraform-aws-security-group

Terraform module to provision an AWS Security Group

https://cloudposse.com/accelerate

Apache License 2.0

36 stars 35 forks source link

More accurate control of create before destroy behaviors #35

Closed Nuru closed 2 years ago

Nuru commented 2 years ago

note

README and code are (hopefully) final.

This will be released as v2.0.0-rc1 due to changed defaults, requirement for Terraform 1.0, and possible service interruption when upgrading. Migration document TBD.

what

Make create_before_destroy default to true for security groups
Introduce preserve_security_group_id to control replacement of security group when rules change

why

In most cases, replacing a security group with create_before_destroy = false will fail with an error because you cannot destroy a security group while it is associated with a resource
Fixes #34

references

Nuru commented 2 years ago

/test all

Nuru commented 2 years ago

/test all

Nuru commented 2 years ago

/test all

Nuru commented 2 years ago

/test all

Nuru commented 2 years ago

/test all

Nuru commented 2 years ago

/test all

osterman commented 2 years ago

Great depiction of the problem at a high-level. This is a great addition to the README.

Nuru commented 2 years ago

/test all