cloudposse / terraform-aws-ssm-parameter-store

Terraform module to populate AWS Systems Manager (SSM) Parameter Store with values from Terraform. Works great with Chamber.
https://cloudposse.com/accelerate
Apache License 2.0
107 stars 61 forks source link

make parameter_write idempotent #27

Closed dennybaa closed 3 years ago

dennybaa commented 3 years ago

resolves https://github.com/cloudposse/terraform-aws-ssm-parameter-store/pull/17

dennybaa commented 3 years ago

/test all

maximmi commented 3 years ago

/test all

dennybaa commented 3 years ago

CI fails:

[contrib-1 81fd85f] Auto Format
 2 files changed, 28 insertions(+), 2 deletions(-)
+ [[ dennybaa == \c\l\o\u\d\p\o\s\s\e\b\o\t ]]
+ git push
remote: Permission to dysnix/terraform-aws-ssm-parameter-store.git denied to cloudpossebot.
fatal: unable to access 'https://github.com/dysnix/terraform-aws-ssm-parameter-store/': The requested URL returned error: 403
Error: Process completed with exit code 128.
osterman commented 3 years ago

/test all

osterman commented 3 years ago

/rebuild-readme

SweetOps commented 3 years ago

dennybaa, LGTM just one nitpick (see requested changes)

CI fails:

could you run the following commands locally and commit:

make init
make readme
terraform fmt
dennybaa commented 3 years ago

dennybaa, LGTM just one nitpick (see requested changes)

CI fails:

could you run the following commands locally and commit:

make init
make readme
terraform fmt

np. done

SweetOps commented 3 years ago

/test all

SweetOps commented 3 years ago

/test readme

SweetOps commented 3 years ago

/test all