Fix: `var.enabled` for Parameter Read, Testing Suite Overhaul - Githubissues

cloudposse / terraform-aws-ssm-parameter-store

Terraform module to populate AWS Systems Manager (SSM) Parameter Store with values from Terraform. Works great with Chamber.

https://cloudposse.com/accelerate

Apache License 2.0

107 stars 61 forks source link

Fix: `var.enabled` for Parameter Read, Testing Suite Overhaul #33

Closed korenyoni closed 2 years ago

korenyoni commented 2 years ago

what

Fix var.parameter_read not honoring var.enabled.
Overhaul tests to properly test for map output.
Overhaul tests to have a parallel test for a disabled context.
Test that module outputs work as expected in both enabled and disabled contexts.
Misc: Fix README snippets.
Misc: Bump module in examples/complete.

why

This module will still read from SSM Parameter Store even if var.enabled is false.
Tests are not sufficient to test for the use case described above.
Tests do not properly test map output.
Misc: README is out of date (git source instead of Terraform registry).

references

N/A

korenyoni commented 2 years ago

/test all