cloudposse / terraform-aws-ssm-parameter-store

Terraform module to populate AWS Systems Manager (SSM) Parameter Store with values from Terraform. Works great with Chamber.
https://cloudposse.com/accelerate
Apache License 2.0
109 stars 60 forks source link

Deprecated `overwrite` parameter #58

Open nitrocode opened 7 months ago

nitrocode commented 7 months ago

Describe the Bug

After a terraform apply

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
╷
│ Warning: Argument is deprecated
│ 
│   with module.ses.module.ses_user.module.store_write[0].aws_ssm_parameter.default["/system_user/ccp-dev/access_key_id"],
│   on .terraform/modules/ses.ses_user.store_write/main.tf line 22, in resource "aws_ssm_parameter" "default":
│   22:   overwrite       = each.value.overwrite
│ 
│ this attribute has been deprecated
│ 
│ (and one more similar warning elsewhere)

From upstream docs

Warning overwrite also makes it possible to overwrite an existing SSM Parameter that's not created by Terraform before. This argument has been deprecated and will be removed in v6.0.0 of the provider. For more information on how this affects the behavior of this resource, see this issue comment.

Expected Behavior

No deprecation warning

Steps to Reproduce

Run terraform apply using this module

Screenshots

No response

Environment

No response

Additional Context

msrdjan commented 6 months ago

Looks like this won't (can't) be removed until v6.0.0 of the provider is released. See cd25893.

joe-niland commented 6 months ago

Related: https://github.com/cloudposse/terraform-aws-ssm-tls-ssh-key-pair/pull/27#issuecomment-2047199276