search

cloudposse / terraform-aws-tfstate-backend

Terraform module that provision an S3 bucket to store the `terraform.tfstate` file and a DynamoDB table to lock the state file to prevent concurrent modifications and state corruption.
https://cloudposse.com/accelerate
Apache License 2.0
408 stars 177 forks source link

Chore/118 fix deprecation warnings #119

Closed vanastassiou closed 1 year ago

vanastassiou commented 2 years ago

what

Partially resolves deprecation warnings during terraform plan and terraform apply. Uses https://github.com/nozaq/terraform-aws-remote-state-s3-backend as a model. Remaining deprecation warnings should probably be corrected in a PR to in https://github.com/cloudposse/terraform-aws-s3-bucket (referenced in the log_storage module code used in this module).

why

references

aknysh commented 2 years ago

/test all

vanastassiou commented 2 years ago

HI @aknysh, thanks for the review. I've pushed changes that give me a terraform plan with no errors on Terraform 1.2.6.

aknysh commented 2 years ago

/test all

aknysh commented 2 years ago

/test all

vanastassiou commented 2 years ago

The warnings that are blocking the terratest job are probably due to the s3-bucket module needing to be updated similarly. I'll submit a PR for that one and then notify here once that's resolved.

Never mind that...Not sure what's causing the context deadline exceeded errors here unfortunately. Any thoughts @aknysh ?

vanastassiou commented 2 years ago

@joe-niland @RothAndrew any guidance on how I should address the context deadline exceeded error in terratest?

RothAndrew commented 2 years ago

Not sure, maybe just a hiccup. will try running the tests again

RothAndrew commented 2 years ago

/test all

RothAndrew commented 2 years ago

The terratest test passed this time, which means the failure was just AWS having a hiccup.

This looks like more than just a chore/refactor though, as it is making breaking changes to the inputs.

@aknysh, who's the right person to put this in front of to make sure this is a change we want to make? I don't have enough context on this module to give it the review it needs.

aknysh commented 2 years ago

/test all

nitrocode commented 2 years ago

/test test/readme

Nuru commented 2 years ago

/rebuild-readme

Nuru commented 2 years ago

/test readme

Nuru commented 2 years ago

/test bats terratest

matthewmrichter commented 1 year ago

Any chance this PR could get a little more attention?

vanastassiou commented 1 year ago

@matthewmrichter thanks for pinging me -- this had fallen off my radar. I should be able to devote some time to it in the coming week.