search

cloudposse / terraform-aws-tfstate-backend

Terraform module that provision an S3 bucket to store the `terraform.tfstate` file and a DynamoDB table to lock the state file to prevent concurrent modifications and state corruption.
https://cloudposse.com/accelerate
Apache License 2.0
408 stars 177 forks source link

Reimplement with "cloudposse/terraform-aws-s3-bucket" to standardize parameters/features #140

Open gw0 opened 1 year ago

gw0 commented 1 year ago

Describe the Feature

I am wondering if there is a specific reason why this https://github.com/cloudposse/terraform-aws-tfstate-backend is not implemented with https://github.com/cloudposse/terraform-aws-s3-bucket? The parameters and features of both also differ.

It would be awesome if parameters (e.g. s3_object_ownership = "BucketOwnerEnforced" vs bucket_ownership_enforced_enabled = true) and features (e.g. lifecycle_configuration_rules) of both would be standardized. Reimplementing one with the other will likely prevent further drift.

Expected Behavior

Standardized parameters/features of similar TF modules.

Use Case

/

Describe Ideal Solution

/

Alternatives Considered

No response

Additional Context

No response

Gowiem commented 5 months ago

Not sure if this will ever be done as this module is largely stable and reimplementing would require a good deal of re-work by maintainers and consumers of this module.

cc @Nuru as he'll likely have a definitive opinion on whether or not to keep this open 👍