Add China arn compatibility. Use arn_prefix var for determinate which… - Githubissues

cloudposse / terraform-aws-tfstate-backend

Terraform module that provision an S3 bucket to store the `terraform.tfstate` file and a DynamoDB table to lock the state file to prevent concurrent modifications and state corruption.

https://cloudposse.com/accelerate

Apache License 2.0

408 stars 177 forks source link

Add China arn compatibility. Use arn_prefix var for determinate which… #41

Closed gloterman closed 4 years ago

gloterman commented 4 years ago

Add China arn compatibility. Use arn_prefix var for determinate which ARN to use

what

Adapt the AWS ARN prefix pour S3 bucket resource.
Add a 'arn_prefix' local var in main.tf, the value is set related of the AWS region var.
In the S3 bucket policy template, add the 'local.arn_prefix' var in prefix of resources.
the 'arn_prefix' default value is set to 'arn:aws"

why

Because for China region the ARN is 'arn:aws-cn', instead of 'arn:aws' for all other regions.
It would be best if this module is available for all AWS regions.
In my business case we deploy in many regions, included China.

references

no reference, business case encountered in China region deployments.

ericamador commented 4 years ago

I believe https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/39 should now address this issue.

osterman commented 4 years ago

thanks @ericamador for the contribution. Yes #39 will replace this one as a generalied way to handle ARNs for any situation.

https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/39