Make public access lock optional - Githubissues

cloudposse / terraform-aws-tfstate-backend

Terraform module that provision an S3 bucket to store the `terraform.tfstate` file and a DynamoDB table to lock the state file to prevent concurrent modifications and state corruption.

https://cloudposse.com/accelerate

Apache License 2.0

408 stars 177 forks source link

Make public access lock optional #48

Closed RothAndrew closed 4 years ago

RothAndrew commented 4 years ago

what

Make the S3 Bucket Public Access Block optional by introducing a new variable enable_public_access_block with default of true to preserve previous behavior

why

To be perfectly honest, because my company for some unknown reason has the ability to create the public access block on their deny list.
More generally, it adds a bit more flexibility with only tiny added complexity. If people don't use it, the module will function no differently than before this variable was added.

references

none

notes

I'm not sure why so much changed in the readme. I ran make init and make readme. Maybe a change in the version of terraform-docs?

RothAndrew commented 4 years ago

/test all

RothAndrew commented 4 years ago

Thanks @Gowiem. Let's wait to merge this though until the chatops has been added. I'm submitting the PR for that in a few minutes.

Gowiem commented 4 years ago

@RothAndrew I think we need @osterman or someone from CP to merge due to the old CodeFresh test.

RothAndrew commented 4 years ago

/test all