search

cloudposse / terraform-aws-transfer-sftp

https://cloudposse.com/accelerate
Apache License 2.0
29 stars 46 forks source link

Fixing 'id' output to properly output the disambiguated ID of the provisioned AWS Transfer Server #21

Closed girdot closed 6 months ago

girdot commented 2 years ago

what

the 'id' output was an empty string, this causes it to be the disambiguated id of the provisioned AWS Transfer Server

references

nitrocode commented 2 years ago

/test all

nitrocode commented 2 years ago

@girdot please update the

https://github.com/cloudposse/terraform-aws-transfer-sftp/blob/d4ee2e12f32c006a2e5910db0509354102d2ea9e/test/src/examples_complete_test.go#L68

Here is the error

s-042a17d9b4f84575b.server.transfer.us-east-2.amazonaws.com
=== CONT  TestExamplesComplete
    examples_complete_test.go:53: 
            Error Trace:    examples_complete_test.go:53
            Error:          Not equal: 
                            expected: "eg-ue2-test-example-43825"
                            actual  : "s-042a17d9b4f84575b"

Please also use the pr template as that will be used for the release notes

mergify[bot] commented 2 years ago

This pull request is now in conflict. Could you fix it @girdot? 🙏