cloudposse / terraform-aws-transfer-sftp

https://cloudposse.com/accelerate
Apache License 2.0
29 stars 48 forks source link

Support `endpoint_type` of `VPC_ENDPOINT` #4

Open bradj opened 3 years ago

bradj commented 3 years ago

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

Currently, this module only supports endpoint type of VPC. This allows SFTP access from VPC subnets but requires updating the aws_transfer_server resource to mange which subnets have SFTP access. Also, each subnet will have a different private IP for the transfer server.

Using an endpoint type of VPC_ENDPOINT allows us to manage subnets and security groups directly on the VPC endpoint resource instead of the transfer server resource while also providing much more flexibility in deciding who can access the endpoint.

Additional Context

pmcdonald-metropolis commented 1 year ago

Bump! This is a much needed feature.

jamengual commented 1 year ago

PRs are welcome.

pmcdonald-metropolis commented 1 year ago

Nevermind: Discontinuing the use of VPC_ENDPOINT AWS Transfer Family is discontinuing the ability to create servers with EndpointType=VPC_ENDPOINT for new AWS accounts. As of May 19, 2021, AWS accounts that don't own AWS Transfer Family servers with an endpoint type of VPC_ENDPOINT will not be able to create new servers with EndpointType=VPC_ENDPOINT. If you already own servers that use the VPC_ENDPOINT endpoint type, we recommend that you start using EndpointType=VPC as soon as possible. For details, see Update your AWS Transfer Family server endpoint type from VPC_ENDPOINT to VPC.