search

cloudposse / terraform-aws-transit-gateway

Terraform module to provision AWS Transit Gateway, AWS Resource Access Manager (AWS RAM) Resource, and share the Transit Gateway with the Organization or another AWS Account.
https://cloudposse.com/accelerate
Apache License 2.0
53 stars 47 forks source link

Minimum version of the aws provider incorrect in module versions > 0.6.1 #24

Closed jbouse closed 2 years ago

jbouse commented 2 years ago

Found a bug? Maybe our Slack Community can help.

Slack Community

Describe the Bug

In versions.tf the aws provider requirement is set as >= 3.0; however in version 0.7.0 the transit_gateway_cidr_blocks argument was introduced into the aws_ec2_transit_gateway resource definition. Unfortunately, the transit_gateway_cidr_blocks argument is only valid in aws provider versions >= 4.4.0 when it was introduced. Even passing the value as null, as is the variable default value, it will still complain about the invalid argument.

Expected Behavior

Would expect that the module would require a version of the aws provider that meets the requirement of the module code as written. This would mean requiring version >= 4.4.0. v0.6.1 is currently the last released version that supports the aws provider < 4.4.0.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Add module > 0.6.1 to an environment using aws provider <= 4.4.0
  2. Execute terraform plan
  3. See the error about transit_gateway_cidr_blocks is not expected here.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas: