search

cloudposse / terraform-aws-transit-gateway

Terraform module to provision AWS Transit Gateway, AWS Resource Access Manager (AWS RAM) Resource, and share the Transit Gateway with the Organization or another AWS Account.
https://cloudposse.com/accelerate
Apache License 2.0
53 stars 47 forks source link

Updating default value description to match actual default value #26

Closed joshuabalduff closed 6 months ago

joshuabalduff commented 2 years ago

what

default_route_table_association and default_route_table_propagation are set to disable so the description should reflect default values that to avoid possible confusion.

why

So it matches :) unless the default value really should be enable

references

Gowiem commented 7 months ago

Good catch @joshuabalduff -- Thanks for this!

Unfortunately, we need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?

make init
make readme

Thanks!

hans-d commented 6 months ago

/terratest

Gowiem commented 6 months ago

@joshuabalduff friendly ping on this work -- can you follow the readme instructions I outlined above and we'll get this shipped.

hans-d commented 6 months ago

38

hans-d commented 6 months ago

@Gowiem can we make this a patch release?

hans-d commented 6 months ago

/terratest

Gowiem commented 6 months ago

@hans-d hm... patch vs no-release here is interesting. I see this as just a docs fix, which means there is no real patch. But I can see the point as we'd want people to download the correct docs to their local module. I'm fine with patch.