Allow setting amazon_side_asn - Githubissues

cloudposse / terraform-aws-transit-gateway

Terraform module to provision AWS Transit Gateway, AWS Resource Access Manager (AWS RAM) Resource, and share the Transit Gateway with the Organization or another AWS Account.

https://cloudposse.com/accelerate

Apache License 2.0

53 stars 47 forks source link

Allow setting amazon_side_asn #50

Closed BFarand closed 1 month ago

BFarand commented 3 months ago

what

The new variable 'amazon_side_asn' was added to the module with a default value of 64512 (AWS default, preserving current behaviour).
Variable 'amazon_side_asn' is now provided as an argument to the 'aws_ec2_transit_gateway.default' resource.
Documentation updated accordingly.

why

Allows the ASN of a transit gateway to be set, allowing the best practice of having multiple transit gateways used in the same deployment to have different ASNs (https://docs.aws.amazon.com/vpc/latest/tgw/tgw-best-design-practices.html)
In cases where a user is importing their existing infrastructure so it is managed via terraform, specifying the existing ASN means that the existing transit gateway does not need to be destroyed and recreated

references

closes #27
updated version of #29

mergify[bot] commented 1 month ago

💥 This pull request now has conflicts. Could you fix it @BFarand? 🙏

mergify[bot] commented 1 month ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.