search

cloudposse / terraform-aws-vpc-peering-multi-account

Terraform module to provision a VPC peering across multiple VPCs in different accounts by using multiple providers
https://cloudposse.com/accelerate
Apache License 2.0
129 stars 92 forks source link

Improvement/tf0.12 #15

Closed slaughtr closed 4 years ago

slaughtr commented 4 years ago

Some vars used "true" instead of bool true, changed those and added type. Updated terraform-null-label from 0.3.3 to 0.16.0 (latest at time of commit). Remove local.enabled in all cases, replace with var.enabled. I believe this was only used due to 0.11 boolean issues, which - as far as I know/have seen - are no longer an issue in 0.12.

Not sure how the whole README build process works, exactly.

slaughtr commented 4 years ago

I'll see if I can get to this, but can't make any guarantees. Looks like it should be a simple duplication of the testing from the repo you linked so hopefully I can 🤞