search

cloudposse / terraform-aws-vpc-peering-multi-account

Terraform module to provision a VPC peering across multiple VPCs in different accounts by using multiple providers
https://cloudposse.com/accelerate
Apache License 2.0
129 stars 92 forks source link

Add some code to allow dns resolution #2

Closed chrisdotm closed 5 years ago

chrisdotm commented 5 years ago

Allow for dns resolution across vpc peers spanning multiple caccounts

chrisdotm commented 5 years ago

Looks like that CI fails even on master. I don't think the linter likes having variables named outside the template using them. It's dying on ${var.stage} which I didn't change.

chrisdotm commented 5 years ago

Made the requested changes.

aknysh commented 5 years ago

@lofidellity thanks. Was it tested on AWS (terraform apply)?

aknysh commented 5 years ago

please also run terraform fmt on all TF files TravisCI is failing https://travis-ci.org/cloudposse/terraform-aws-vpc-peering-multi-account/builds/490675953

aknysh commented 5 years ago

@lofidellity can you please address the latest comments so we could merge it?

chrisdotm commented 5 years ago

yes I am using this code across multiple accounts in my terraform codebase.