cloudposse / terraform-aws-vpc-peering-multi-account

Terraform module to provision a VPC peering across multiple VPCs in different accounts by using multiple providers
https://cloudposse.com/accelerate
Apache License 2.0
129 stars 92 forks source link

3.x AWS provider not supported #24

Closed sgrimm closed 3 years ago

sgrimm commented 3 years ago

Describe the Bug

The module requires version 2.x of the AWS provider, which is no longer under active development.

Expected Behavior

If included in a project that uses version 3.x of the AWS provider, the module should work properly.

Steps to Reproduce

Reference the module from a project with a newer version of the AWS provider, e.g., one that has

terraform {
  required_providers {
    aws = {
      source  = "aws"
      version = "~> 3.10"
    }
  }
}

Running terraform init will print an error because it can't satisfy the version constraints of the project and the module at the same time.

Environment (please complete the following information):

Terraform 0.13.4, AWS provider 3.10.0.

Additional Context

I tried modifying a local copy of the module to relax the version constraint (changed it from ~> 2.0 to >= 2.0) and it appeared to work fine with provider version 3.10.0, though I didn't test every possible permutation of inputs.