Closed jbouse closed 2 years ago
@Nuru this is a modification I was working on locally and mentioned in last weeks office hours. Was suggested I run past you to get your thoughts.
/test all
@jbouse sorry for the late review.
Tests are failing because of conflicting arguments at the provider level:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: Error: Conflicting configuration arguments
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: on ../../main.tf line 17, in resource "aws_vpc" "default":
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: 17: cidr_block = var.cidr_block
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: "cidr_block": conflicts with ipv4_netmask_length
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: Error: Missing required argument
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: on ../../main.tf line 19, in resource "aws_vpc" "default":
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: 19: ipv4_netmask_length = var.ipv4_netmask_length
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66:
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: "ipv4_netmask_length": all of `ipv4_ipam_pool_id,ipv4_netmask_length` must be
TestExamplesComplete 2022-02-10T17:42:02Z logger.go:66: specified
@korenyoni I'll go back and take another look at this... The use case I'm working on is being able to use AWS IPAM when deploying out the VPC so it would either use cidr_block
or ipv4_ipam_pool_id
& ipv4_netmask_length
. The two should be mutually exclusive. You couldn't set all 3 variables obviously as they would conflict.
/test all
@jbouse IPv6 and IPAM support released in v1.1.0. Please try it out and report any issues.
what
ipv4_ipam_pool_id
&ipv4_netmask_length
variablescidr_block
with default value ofnull
cidr_block
is mutually exclusive to usingipv4_ipam_pool_id
andipv4_netmask_length
why
cidr_block
auto-assignment for a VPC provided from an AWS VPC IPAM pool