Closed esolitos closed 7 months ago
I just added the suggestions for now. Will try to update the rest when I have some extra minutes. :)
Edit: And of course.. Thank you for the review. 👍🏼 👍🏼
/terratest
@esolitos friendly ping on the above -- Would love to get this in as it looks like a solid implementation. Please give it another pass when you get the chance!
/terratest
Thanks for the reminder. :)
/terratest
Thanks @esolitos for creating this pull request!
A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.
While you wait, make sure to review our contributor guidelines.
[!TIP]
Need help or want to ask for a PR review to be expedited?
Join us on Slack in the
#pr-reviews
channel.
[!IMPORTANT]
Cloud Posse Engineering Team Review Required
This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.
To expedite this process, reach out to us on Slack in the
#pr-reviews
channel.
what
Implemented ability to set log to cloudwatch.
cloudposse/cloudwatch-logs/aws
to create a logging groupvpn_connection_tunnel1_cloudwatch_log_enabled
andvpn_connection_tunnel2_cloudwatch_log_enabled
to allow enabling logging for a specific tunnelvpn_connection_log_retention_in_days
to allow configuring logs retentionmake
actions to sync, as recommended in another PR.why
This allow enabling logging on the tunnels, which was not possible before.
references