cloudposse / terraform-aws-vpn-connection

Terraform module to provision a site-to-site VPN connection between a VPC and an on-premises network
https://cloudposse.com/accelerate
Apache License 2.0
61 stars 58 forks source link

feat: add logging options #26

Closed esolitos closed 7 months ago

esolitos commented 1 year ago

what

Implemented ability to set log to cloudwatch.

why

This allow enabling logging on the tunnels, which was not possible before.

references

esolitos commented 8 months ago

I just added the suggestions for now. Will try to update the rest when I have some extra minutes. :)

Edit: And of course.. Thank you for the review. 👍🏼 👍🏼

hans-d commented 8 months ago

/terratest

Gowiem commented 8 months ago

@esolitos friendly ping on the above -- Would love to get this in as it looks like a solid implementation. Please give it another pass when you get the chance!

Gowiem commented 8 months ago

/terratest

esolitos commented 8 months ago

Thanks for the reminder. :)

Gowiem commented 8 months ago

/terratest

mergify[bot] commented 7 months ago

Thanks @esolitos for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] commented 7 months ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.