Closed JohnShortland closed 1 year ago
@JohnShortland thanks for the PR
please run the following commands locally and commit the changes
make init
make github/init
make readme
@JohnShortland thanks for the PR
please run the following commands locally and commit the changes
make init make github/init make readme
Running these doesn't seem to work, I would expect to see changes afterward.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make init
Removing existing build-harness
Cloning https://github.com/cloudposse/build-harness.git#master...
Cloning into 'build-harness'...
remote: Enumerating objects: 156, done.
remote: Counting objects: 100% (156/156), done.
remote: Compressing objects: 100% (130/130), done.
remote: Total 156 (delta 8), reused 83 (delta 4), pack-reused 0
Receiving objects: 100% (156/156), 100.73 KiB | 2.58 MiB/s, done.
Resolving deltas: 100% (8/8), done.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make github/init
make: *** No rule to make target 'github/init'. Stop.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make readme
make: *** No rule to make target 'readme'. Stop.
/terraform-fmt
@JohnShortland sorry again, but to pass the tests, you need to run terraform fmt
on all TF code (including the example), and also format/generate README by running the following commands locally from the root of the repo
make init
make github/init
make readme
@aknysh Ready for another review, I think I've covered everything now. Thanks for the pointers.
/terratest
/terratest
what
why
references
closes #22