cloudposse / terraform-cloudflare-zone

Terraform module to provision a CloudFlare zone with DNS records, Argo, Firewall filters and rules
https://cloudposse.com/accelerate
Apache License 2.0
27 stars 19 forks source link

Add account_id to allow module to function #24

Closed JohnShortland closed 1 year ago

JohnShortland commented 1 year ago

what

why

Planning changes with 0 custom hooks...
Error: Missing required argument
on .terraform/modules/zone/main.tf line 23, in resource "cloudflare_zone" "default":
23: resource "cloudflare_zone" "default" {
The argument "account_id" is required, but no definition was found.
Unexpected exit code when planning changes: 1

references

closes #22

aknysh commented 1 year ago

@JohnShortland thanks for the PR

please run the following commands locally and commit the changes

make init
make github/init
make readme
JohnShortland commented 1 year ago

@JohnShortland thanks for the PR

please run the following commands locally and commit the changes

make init
make github/init
make readme

Running these doesn't seem to work, I would expect to see changes afterward.

vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make init
Removing existing build-harness
Cloning https://github.com/cloudposse/build-harness.git#master...
Cloning into 'build-harness'...
remote: Enumerating objects: 156, done.
remote: Counting objects: 100% (156/156), done.
remote: Compressing objects: 100% (130/130), done.
remote: Total 156 (delta 8), reused 83 (delta 4), pack-reused 0
Receiving objects: 100% (156/156), 100.73 KiB | 2.58 MiB/s, done.
Resolving deltas: 100% (8/8), done.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make github/init
make: *** No rule to make target 'github/init'.  Stop.
vscode ➜ /workspaces/Git Repos/terraform-cloudflare-zone (main) $ make readme
make: *** No rule to make target 'readme'.  Stop.
aknysh commented 1 year ago

/terraform-fmt

aknysh commented 1 year ago

@JohnShortland sorry again, but to pass the tests, you need to run terraform fmt on all TF code (including the example), and also format/generate README by running the following commands locally from the root of the repo

make init
make github/init
make readme
JohnShortland commented 1 year ago

@aknysh Ready for another review, I think I've covered everything now. Thanks for the pointers.

aknysh commented 1 year ago

/terratest

aknysh commented 1 year ago

/terratest