cloudposse / terraform-cloudflare-zone

Terraform module to provision a CloudFlare zone with DNS records, Argo, Firewall filters and rules
https://cloudposse.com/accelerate
Apache License 2.0
27 stars 19 forks source link

Add comment support to records #49

Closed glensc closed 2 months ago

glensc commented 2 months ago

Simple string value. As record is typed as any, no documentation changes.

RoseSecurity commented 2 months ago

@glensc Thanks for the contribution! Is there any way you would also be able to add a description entry for comments in the record variable?

glensc commented 2 months ago

41e086c19a7b14f47a19a6713998321ebb4a8ac0

RoseSecurity commented 2 months ago

/terratest

RoseSecurity commented 2 months ago

/terratest

RoseSecurity commented 2 months ago

I believe the tests are failing due to a previous subscription update, but this looks good to me

github-actions[bot] commented 2 months ago

These changes were released in v1.0.1.

glensc commented 2 months ago

Any take on https://github.com/cloudposse/terraform-cloudflare-zone/pull/48?