cloudscale-ch / ansible-collection-cloudscale

cloudscale.ch Ansible Collection
https://galaxy.ansible.com/cloudscale_ch/cloud
GNU General Public License v3.0
7 stars 3 forks source link

Rename server_uuids parameter to servers in volume module #54

Closed ctx closed 3 years ago

gaudenz commented 3 years ago

This now looks good from my point of view. But I'd prefer @href to have a quick look at my deprecation commit.

href commented 3 years ago

Looks good to me, go ahead and merge at will.

resmo commented 3 years ago

I see a missed opportunity:

What about using a list of objects as param (similar what is returned by the api)?

Advantages:

by server uuid

- cloudscale_ch.cloud.volume:
    uuid: "{{ my_ssd_volume.uuid }}"
    servers:
    - uuid: ea3b39a3-77a8-4d0b-881d-0bb00a1e7f48

by server name

- cloudscale_ch.cloud.volume:
    uuid: "{{ my_ssd_volume.uuid }}"
    servers:
    - name: my-server
ctx commented 3 years ago

Thanks for this suggestion, I created an issue. We will find more parameters which could take a name or an uuid and even an object: https://github.com/cloudscale-ch/ansible-collection-cloudscale/issues/56