search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

chore: Treat CSS containment as containing block for positioning #2283

Closed avinashbot closed 1 month ago

avinashbot commented 1 month ago

Description

Just getting ahead of any possible future need (container queries 😉). Right now, there's no use-case for it directly in the components itself, but it does bring it closer in line with native browser layout behavior, should people end up doing container queries on their end.

Related links, issue #, if available: n/a

How has this been tested?

No tests, just manual messing around. Just getting ahead of potential future changes where we use container queries ourselves and the popover ends up breaking.

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (8b62025) to head (7429f87).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2283 +/- ## ======================================== Coverage 95.44% 95.44% ======================================== Files 707 707 Lines 18802 18804 +2 Branches 6307 5988 -319 ======================================== + Hits 17945 17947 +2 Misses 849 849 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.