search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

chore: Do not emit performance marks for buttons inside modals #2287

Closed connorlanigan closed 4 months ago

connorlanigan commented 4 months ago

Description

This PR updates the logic for emitting performance marks. They will no longer be emitted for components that are located inside Modals.

Related links, issue #, if available: AWSUI-44575

How has this been tested?

Added a unit test, and manually verified in the new dev page

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (e12b3ca) to head (2f2eb08).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2287 +/- ## ======================================== Coverage 95.43% 95.44% ======================================== Files 707 707 Lines 18810 18811 +1 Branches 6273 5992 -281 ======================================== + Hits 17952 17954 +2 - Misses 804 849 +45 + Partials 54 8 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.