cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

chore: Mobile view support for skeleton app layout #2291

Closed just-boris closed 4 months ago

just-boris commented 4 months ago

Description

Follow up for https://github.com/cloudscape-design/components/pull/2276, adding mobile view support

Related links, issue #, if available: n/a

How has this been tested?

Locally using existing dev page

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (1652fad) to head (402a6ee). Report is 1 commits behind head on main.

:exclamation: Current head 402a6ee differs from pull request most recent head f57a797

Please upload reports for the commit f57a797 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2291 +/- ## ======================================== Coverage 95.44% 95.44% ======================================== Files 707 707 Lines 18805 18805 Branches 6318 5988 -330 ======================================== Hits 17948 17948 - Misses 803 849 +46 + Partials 54 8 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.