cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

feat: Add onClick event for Link component #2295

Closed YueyingLu closed 1 month ago

YueyingLu commented 1 month ago

Description

Add onClick event for Link component.

Currently Link has one event: onFollow, which is called when the Link is called without modifier key. Our customer needs an event calls for every onClick to collect metrics.

Related links, issue #, if available: n/a

How has this been tested?

Add unit tests
Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.49%. Comparing base (0507984) to head (d8a60b0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2295 +/- ## ========================================== + Coverage 95.47% 95.49% +0.01% ========================================== Files 706 706 Lines 18811 18818 +7 Branches 6273 5994 -279 ========================================== + Hits 17960 17970 +10 - Misses 798 840 +42 + Partials 53 8 -45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.