cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

feat: Removal of high-contrast header and additional header styling APIs #2297

Closed fralongo closed 4 months ago

fralongo commented 4 months ago

Description

Accumulates

https://github.com/cloudscape-design/components/pull/2144 https://github.com/cloudscape-design/components/pull/2142 https://github.com/cloudscape-design/components/pull/2146 https://github.com/cloudscape-design/components/pull/2148 https://github.com/cloudscape-design/components/pull/2150

Related links, issue #, if available: n/a

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.44%. Comparing base (639ee16) to head (dcc0e14). Report is 1 commits behind head on main.

Files Patch % Lines
src/internal/utils/content-header-utils.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2297 +/- ## ========================================== - Coverage 95.45% 95.44% -0.01% ========================================== Files 707 707 Lines 18788 18808 +20 Branches 6294 6302 +8 ========================================== + Hits 17934 17952 +18 - Misses 800 848 +48 + Partials 54 8 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.