cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

chore: Fix transparent background color for app layout skeleton #2299

Closed just-boris closed 4 months ago

just-boris commented 4 months ago

Description

Fixing feature parity between app layout and its skeleton sub-part

Related links, issue #, if available: n/a

How has this been tested?

Locally. Not visible on screenshot tests yet, because my skeleton dev page is still work in progress.

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.44%. Comparing base (a400df1) to head (14f8cd5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2299 +/- ## ======================================= Coverage 95.44% 95.44% ======================================= Files 706 706 Lines 18803 18803 Branches 5981 5981 ======================================= Hits 17947 17947 Misses 848 848 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.