codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.46%. Comparing base (
6180f84) to head (698c806).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2305 +/- ## ======================================= Coverage 95.45% 95.46% ======================================= Files 705 705 Lines 18832 18833 +1 Branches 6309 6309 ======================================= + Hits 17977 17978 +1 + Misses 847 801 -46 - Partials 8 54 +46 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Found in Slack and I'm following up with a quick fix, so no ticket. There are two things here that need to be labelled - the table itself (if there are multiple tables) and the focusable scroll wrapper (if the table is horizontally scrollable). Previously, we used to "auto-label" the former from the header slot, but not the latter.
Related links, issue #, if available: n/a
How has this been tested?
Removed a manual label from a test page and the test should continue to pass. No unit test changes because we can't reliably make the scrollable wrapper show up on unit tests.
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.