cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.34k stars 152 forks source link

fix: Fix select overflow when using in table inline editing #2312

Closed pan-kot closed 3 months ago

pan-kot commented 4 months ago

Description

When using select component with very long option labels in table with inline editing the component expands beyond cell borders.

https://github.com/cloudscape-design/components/assets/20790937/53bc2866-9d01-428c-a700-ec93bc01dfce

Rel: AWSUI-42444

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.50%. Comparing base (21bed91) to head (de7c014). Report is 18 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2312 +/- ## ========================================== + Coverage 95.48% 95.50% +0.02% ========================================== Files 706 706 Lines 18808 18877 +69 Branches 5987 6003 +16 ========================================== + Hits 17958 18028 +70 + Misses 842 841 -1 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

YueyingLu commented 3 months ago

Visual Regression tests failed as expected, because new permutation added to table editors.

pan-kot commented 3 months ago

Looks good to me! (but can't approve because I authored the branch)