search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

chore: Remove dynamic overlap hook from wizard #2323

Closed fralongo closed 1 month ago

fralongo commented 1 month ago

Description

No longer needed after the removal of high-contrast header

Related links, issue #, if available: n/a

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

connorlanigan commented 1 month ago

These wizard styles look like they could be related to the dark header, do they need to be updated too?

https://github.com/cloudscape-design/components/blob/d369b8f56d65c604f1dc3aea233d0ebe58a272d7/src/wizard/styles.scss#L226-L238

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.46%. Comparing base (6ceb70c) to head (d369b8f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2323 +/- ## ========================================== - Coverage 95.46% 95.46% -0.01% ========================================== Files 706 706 Lines 18758 18757 -1 Branches 6286 6295 +9 ========================================== - Hits 17908 17907 -1 + Misses 842 796 -46 - Partials 8 54 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.