codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.46%. Comparing base (
0dc3c0a) to head (73bf0e6).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2328 +/- ## ======================================= Coverage 95.46% 95.46% ======================================= Files 706 706 Lines 18762 18762 Branches 6249 6289 +40 ======================================= Hits 17912 17912 - Misses 796 842 +46 + Partials 54 8 -46 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
My guess on what's happening here is that CSS contain isn't supported on Safari 15.0, 15.1, and 15.3, so calling a property on it causes an error to throw. Treating this as a hotfix for now, but I don't know how best to address this in the long term. Either an audit on whether properties we're calling on
getComputedStyleexist, or some kind of CSS-like browser-support check?Related links, issue #, if available: AWSUI-45436
How has this been tested?
See above.
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.