cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

feat: Key value pair component flexible layout #2348

Closed georgylobko closed 5 days ago

georgylobko commented 3 weeks ago

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.41935% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.63%. Comparing base (2daa649) to head (3b78760). Report is 15 commits behind head on main.

Files Patch % Lines
...app-layout/visual-refresh-toolbar/drawer/index.tsx 89.28% 3 Missing :warning:
...layout/visual-refresh-toolbar/navigation/index.tsx 84.61% 2 Missing :warning:
src/app-layout/visual-refresh-toolbar/index.tsx 98.61% 1 Missing :warning:
...visual-refresh-toolbar/toolbar/drawer-triggers.tsx 97.72% 1 Missing :warning:
...pp-layout/visual-refresh-toolbar/toolbar/index.tsx 95.23% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2348 +/- ## ========================================== + Coverage 95.50% 95.63% +0.13% ========================================== Files 708 723 +15 Lines 18887 19186 +299 Branches 5998 6108 +110 ========================================== + Hits 18038 18349 +311 + Misses 841 829 -12 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.