cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

fix: Ensure drawer icons remain on right in mobile #2354

Closed gethinwebster closed 3 weeks ago

gethinwebster commented 3 weeks ago

Description

Ensure drawer icons are right-aligned when in VR mobile view and there are no breadcrumbs.

Related links, issue #, if available: AWSUI-46715

How has this been tested?

Tested locally

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.49%. Comparing base (3bf56d4) to head (bb308b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2354 +/- ## ========================================== - Coverage 95.50% 95.49% -0.01% ========================================== Files 706 706 Lines 18877 18877 Branches 6291 6003 -288 ========================================== - Hits 18028 18027 -1 - Misses 795 842 +47 + Partials 54 8 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Al-Dani commented 3 weeks ago

should classic also be fixed?

gethinwebster commented 3 weeks ago

classic works fine already, the bug is only in VR