search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

fix: Clean up icons content #2360

Closed just-boris closed 2 weeks ago

just-boris commented 2 weeks ago

Description

Clean up icons from inline attributes because they conflict with our CSS we apply to the icons: https://github.com/cloudscape-design/components/blob/af1a976051f9de50675d30004475bbe0e3847ffa/src/icon/mixins.scss#L98-L120

Related links, issue #, if available: n/a

How has this been tested?

Screenshot tests in my dev pipeline

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.49%. Comparing base (af1a976) to head (f23b9a3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2360 +/- ## ======================================= Coverage 95.49% 95.49% ======================================= Files 708 708 Lines 18886 18886 Branches 6005 6005 ======================================= Hits 18036 18036 Misses 842 842 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.