Closed just-boris closed 1 week ago
Attention: Patch coverage is 96.95817%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 95.62%. Comparing base (
e1c0652
) to head (9775324
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
General: When testing the app dev pages (with ?appLayoutWidget=true), there is a strange behaviour with the grid when switching to mobile -
https://github.com/cloudscape-design/components/assets/569011/4a90a5c1-ff04-424f-8001-32464043cb13
Steps to reproduce:
Description
Adding new version of app layout to the mainline to avoid permanent rebases
Related links, issue #, if available: n/a
How has this been tested?
Currently, only Typescript build. Making existing app layout tests passing against all design variants will be a separate task
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.