search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

chore: Improve tag editor's compatibility with Google Translate #2391

Closed avinashbot closed 6 days ago

avinashbot commented 1 week ago

Description

As is our precedent, we don't really "guarantee" support with wonky translate extensions (and that's a bug with a long history too), but we still fix them on a best-effort basis. This case seemed simple enough. I couldn't make a reproduction happen on the website or dev pages, but the ticketer does have a consistent repro and a stack trace and a working test with the changed code, and it all checks out to me.

Related links, issue #, if available: V1412289177

How has this been tested?

Not tested at all. Nothing should even change, for tests or for real browsers.

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.50%. Comparing base (e1c0652) to head (ddbb77c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2391 +/- ## ======================================== Coverage 95.49% 95.50% ======================================== Files 708 708 Lines 18887 18887 Branches 5998 6336 +338 ======================================== + Hits 18037 18038 +1 + Misses 842 795 -47 - Partials 8 54 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.