Closed connorlanigan closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.50%. Comparing base (
e1c0652
) to head (0e9ad7f
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR updates the colour tokens used for the Table header background. It used to use the Container tokens, even if the table was in the
full-page
variant, which does not have a (visible) container. After this PR, the table uses the page-level colour tokens when it is in thefull-page
variant.Screenshots
Before![themed before](https://github.com/cloudscape-design/components/assets/9086585/b652c75c-5a1b-4ccb-8d52-1a1a3467d4e7)
After![themed-after](https://github.com/cloudscape-design/components/assets/9086585/fdf3a544-9f10-4a6a-b809-ae7fa0bfee2d)
Related links, issue #, if available: n/a
How has this been tested?
Manual testing in the dev pages
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.