cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

refactor: Update DrawersTriggers internal component props #2411

Closed just-boris closed 4 days ago

just-boris commented 5 days ago

Description

appLayoutInternals is our cross-instances interface. The less we pass it around, the better

Related links, issue #, if available: n/a

How has this been tested?

PR build

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.62%. Comparing base (45da483) to head (5f9bcf1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2411 +/- ## ======================================= Coverage 95.62% 95.62% ======================================= Files 720 720 Lines 19160 19163 +3 Branches 6100 6103 +3 ======================================= + Hits 18322 18325 +3 Misses 830 830 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

just-boris commented 4 days ago

I am planning to change AppLayoutInternals interface and this PR helps to remove DrawersTriggers from the scope of the next PR