codecov[bot]
commented
4 days ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.62%. Comparing base (
45da483) to head (d59d922).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2415 +/- ## ======================================== Coverage 95.62% 95.62% ======================================== Files 720 720 Lines 19160 19160 Branches 6100 6435 +335 ======================================== Hits 18322 18322 + Misses 830 784 -46 - Partials 8 54 +46 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Borderless table in Visual Refresh does not include its own internal paddings so the padding needs to be provided by the container, whereas in Classic the padding from the container needs to be removed.
We have visual regression test for a borderless table inside a container with
disableContentPaddings={true}, which is how it is supposed to be used in Classic, but not inside a container withdisableContentPaddings={false}(or withoutdisableContentPaddingsset), which is how it is supposed to be used in Visual Refresh.How has this been tested?
Existing visual regression tests in the pipeline
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.