search

cloudscape-design / components

React components for Cloudscape Design System
https://cloudscape.design/
Apache License 2.0
2.3k stars 140 forks source link

fix: Full-page table uses container background colours instead of page background colours #2424

Closed connorlanigan closed 1 hour ago

connorlanigan commented 3 days ago

There was a previous PR for this, which was later reverted: #2398

Description

This PR updates the colour tokens used for the Table header background. It used to use the Container tokens, even if the table was in the full-page variant, which does not have a (visible) container. After this PR, the table uses the page-level colour tokens when it is in the full-page variant.

Screenshots

Before themed before

After themed-after

Related links, issue #, if available: n/a

How has this been tested?

Manual testing in the dev pages

Review checklist _The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.62%. Comparing base (e5fdb4a) to head (da1099a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2424 +/- ## ======================================== Coverage 95.62% 95.62% ======================================== Files 720 720 Lines 19163 19164 +1 Branches 6397 6104 -293 ======================================== + Hits 18325 18326 +1 - Misses 784 830 +46 + Partials 54 8 -46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.