codecov[bot]
commented
2 days ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.62%. Comparing base (
63eeffd) to head (105b66a). Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #2428 +/- ## ======================================== Coverage 95.62% 95.62% ======================================== Files 722 722 Lines 19237 19232 -5 Branches 6118 6410 +292 ======================================== - Hits 18395 18391 -4 + Misses 834 787 -47 - Partials 8 54 +46 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Make sure
<Link>component looks the same whether thehrefis set or not.For the former
<Link href={undefined}>styling, use<Button variant="inline-link">Related links, issue #, if available: n/a
How has this been tested?
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.