Closed sderacy closed 3 days ago
Attention: Patch coverage is 96.55172%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 95.65%. Comparing base (
e197f9f
) to head (ad7e644
).
Files | Patch % | Lines |
---|---|---|
src/tabs/tab-header-bar.tsx | 95.77% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
2173 needed to be reverted because it introduced visual regressions which blocked the pipeline. This PR cuts a new PR the previous files and reverts ccaa340 that introduced the breaking visual changes.
This implements:
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
_The following items are to be evaluated by the author(s) and the reviewer(s)._ #### Correctness - _Changes include appropriate documentation updates._ - _Changes are backward-compatible if not indicated, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#public-apis)._ - _Changes do not include unsupported browser features, see [`CONTRIBUTING.md`](https://github.com/cloudscape-design/components/blob/main/CONTRIBUTING.md#browsers-support)._ - _Changes were manually tested for accessibility, see [accessibility guidelines](https://cloudscape.design/foundation/core-principles/accessibility/)._ #### Security - _If the code handles URLs: all URLs are validated through [the `checkSafeUrl` function](https://github.com/cloudscape-design/components/blob/main/src/internal/utils/check-safe-url.ts)._ #### Testing - _Changes are covered with new/existing unit tests?_ - _Changes are covered with new/existing integration tests?_ref: https://github.com/cloudscape-design/components/pull/2173
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.